Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example showing how to build and run a double pulse test simulation in Circuit #273

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

tizianrot
Copy link
Collaborator

Pull Request Template

Description

New example showing how to build and run a double pulse test simulation in Circuit, using components from library. The method to insert a component from a spice model. A picture of the schematic is also added for the gallery. The example is buildig the model available in the Installation examples.

Checklist

Please complete the following checklist before submitting your pull request:

  • [ x] I have followed the example template and guide lines to add/update an example.
  • [ x] I have tested the example locally and verified that it is working with the latest version of AEDT.
  • [ x] I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

…on in Circuit, using components from library. The method to insert a component from a spice model. A picture of the schematic is also added
…on in Circuit, using components from library. The method to insert a component from a spice model. A picture of the schematic is also added

------
modifications added about variable names, Vm and Am assignment and create_report
Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python name conventions

@gmalinve
Copy link
Collaborator

@tizianrot good job with this example! there are a few things to improve.
Could you also open the example in Jupyter and use the Jupytext format to see if the cells are splitted correctly and if the headers have a consistent level?
Thanks!

@gmalinve gmalinve linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 22, 2024 11:36
@gmalinve gmalinve disabled auto-merge November 22, 2024 12:02
@gmalinve gmalinve merged commit 9ff1c1a into main Nov 25, 2024
11 checks passed
@gmalinve gmalinve deleted the feat_new_circuit_doublepulse_example branch November 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example of Double Pulse Test in Circuit - PR #273
3 participants